New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: better `Array#includes` #17 #21

Closed

uinz wants to merge 1 commit into uhyo:master from uinz:master

uinz commented Jan 4, 2023


          feat: better Array#includes uhyo#17

76a5b69

Contributor

graphemecluster commented Jan 4, 2023

As mentioned in #17 (comment), the type guard will cause incorrect type narrowing in the else branch. See #14 and microsoft/TypeScript#15048 for more details.

uinz closed this

Author

uinz commented Jan 5, 2023

narrowing

oh, I missed some infomation.

thank you tell me about that.

but how about only apply it on ReadonlyArray?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment